TeraTerm Support Forums • View topic

syfl_keene · **Joined:** Thu Nov 19, 2009 5:22 am **Posts:** 1

Hello I use this for parsing through a phone system and switching the processors.
Eventually i would like to fully automate it though and want to make sure it's code efficient.

ie any suggestions would be appreciated.

Select all

;tt start and connection variables, turn off with ttstart = 0
ttstart = 0
    span1 = '*.*.*.*:23 /nossh'
    span2 = '*.*.*.*:23 /nossh'
    span3 = '*.*.*.*:23 /nossh'
    span1b = '*.*.*.*:23 /nossh'
    span2b = '*.*.*.*:23 /nossh'
    span3b = '*.*.*.*:23 /nossh'
 
;hdt login info, turn off with hdtlogin = 0
hdtlogin = 0
    hdtun = 'root'
    hdtpw = '*****'
 
;Timeout controls
    sTime = 10 ;finite
    iTime = 0  ;infinite
 
;Speed control
    p1 = 2 ;multiple
    p2 = p1 * 3 ;6
    p3 = p1 * 6 ;12
;muliplier for speed [0 being real time, 10 being ultra slow]
    m1 = 1
;note: this does not affect "waitrecv" lines
;default is 1
 
 
;code begin
timeout = sTime
if hdtlogin = 1 then
        pause p1 * m1
            if ttstart = 1 then
                    connect span1
                    waitrecv 'login:' 6 1
            endif
        sendln hdtun
        sendln hdtpw
        waitrecv 'TERM' 4 1
        sendln #13
        waitrecv 'opc>' 4 1
        pause p1 * m1
endif
crbegin = 1
if crbegin = 1 then
        sendln #13
endif
        goto next
;logging info
        :next
getenv 'USERNAME' username
gettime timestr "%Y%m%d-%H%M%S"
        sprintf2 filename 'console_%s_%s.log' username timestr
        sprintf2 dirname 'C:\Documents and Settings\%s\desktop' username
changedir dirname
logopen filename 0 0
 
timeout = iTime
inputbox 'Which NE:' 'Macro Help'
        sendln 'nelogin' #32 inputstr
            waitrecv 'Enter' 5 1
        sendln 'dkeene'
            waitrecv 'Password' 8 7
        sendln '****'
            waitrecv 'MORE' 7 1
            pause p1 * m1
        sendln #13
            pause p1 * m1
        sendln '3'
            waitrecv 'For' 3 1
            pause p2 * m1
        sendln 'sysmon'
            waitrecv 'SYSMON:' 7 1
        sendln 'cpstats all'
            pause p2 * m1
                for i 1 4
                    sendln #13
                    pause p1 * m1
                    timeout = sTime
                    waitrecv 'MORE' 7 1
                next 
        sendln #13
        
yesnobox 'Note alarms & stats, continue?' 'Macro Help'
    if result = 1 then
        sendln 'eq proc a'
            pause p3 * m1
        sendln 'eq proc b'
            pause p3 * m1
                yesnobox 'Click Yes to continue with SWACT.' 'Macro Help'
                    if result = 0 then 
                       r1 = result
                        yesnobox 'Logout?' 'Macro Help'
                            if result = 1 then
                                    sendln 'logout'
                                    timeout = iTime
                                    waitrecv 'Press' 5 1
                                    sendln #13
                            else
                            exit
                            endif
                    else if r1 = 1 then
                                sendln '9'
                                    pause p1 * m1
                                sendln 'y'
                                    waitrecv 'Press' 5 1
                                    timeout = iTime
                                sendln #13
                    endif
    endif
exit
 

Thanks in advance.

David

IshmaelCallMe · **Posted:** Fri Nov 20, 2009 7:24 am

Suggestions? Sure.

Your indent style is a little strange and inconsistent, but that is just personal preference.

Never, ever, ever use goto statements for any reason whatsoever. They WILL bite you, sooner or later.

This:

Select all

 
crbegin = 1
if crbegin = 1 then
        sendln #13
endif
 

Can be replaced by:

Select all

 
crbegin=1
sendln #13

Other than that, looks good.

sjohn · **Joined:** Wed Dec 02, 2009 12:05 am **Posts:** 3

Hi All,

Can anybody from here give me a detailed explantion of ABAP/4 Development Code Efficiency Guidelines.

Thanks in advance

boris · **Posted:** Mon Dec 07, 2009 10:18 am

sjohn,

SAP programming has nothing to do with TeraTerm, so you rather ask this question in the "right" forum. Also, please check our forum Rules and Regulations that are more strict than on many other web sites - irrelevant postings can cost you warning or even account termination.

As for your question - I just Goggled "ABAP/4" and found this link that may be helpful. No sure about the terms of copyright though, so use your own judgment.

Who is online